Skip to content

[PWGDQ]: update Zorro#8095

Merged
lucamicheletti93 merged 4 commits into
AliceO2Group:masterfrom
zjxiongOvO:master
Oct 29, 2024
Merged

[PWGDQ]: update Zorro#8095
lucamicheletti93 merged 4 commits into
AliceO2Group:masterfrom
zjxiongOvO:master

Conversation

@zjxiongOvO
Copy link
Copy Markdown
Contributor

No description provided.

@alibuild
Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 2dc8d43 at 2024-10-22 16:35:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/8095-slc7_x86-64/0/PWGDQ/TableProducer/tableMaker.cxx:1288:9: error: 'fConfigRunZorro' was not declared in this scope
ninja: build stopped: subcommand failed.

Full log here.

Copy link
Copy Markdown
Collaborator

@mpuccio mpuccio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear @zjxiongOvO, thanks a lot for your PR! Please have a look at my comments and tell me if you agree with those.

Comment thread EventFiltering/Zorro.h Outdated
Comment thread EventFiltering/Zorro.cxx Outdated
@alibuild
Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for c9c6555 at 2024-10-28 06:34:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/8095-slc7_x86-64/0/PWGDQ/TableProducer/tableMaker.cxx:455:9: error: continue statement not within a loop
/sw/SOURCES/O2Physics/8095-slc7_x86-64/0/PWGDQ/TableProducer/tableMaker.cxx:918:9: error: continue statement not within a loop
ninja: build stopped: subcommand failed.

Full log here.

@lucamicheletti93 lucamicheletti93 merged commit 14acbfd into AliceO2Group:master Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants